Improve dev tooling and expand test coverage#26
Merged
dannywillems merged 9 commits intomainfrom Feb 1, 2026
Merged
Conversation
- Add comprehensive Makefile with standard targets (help, test, lint, etc.) - Add .editorconfig for consistent editor settings - Replace black + pylint with ruff for linting and formatting - Add pytest-cov for coverage reporting - Configure mypy with strict settings - Configure pytest with verbose output
- Fix star imports in leakix/__init__.py with explicit re-exports - Fix star imports in leakix/client.py with specific imports - Apply ruff auto-fixes (f-strings, modern super() calls, etc.) - Add __all__ to __init__.py for clear public API
- Add comprehensive tests for Client class initialization - Add tests for all API methods (get, get_service, get_leak, etc.) - Add tests for query classes (MustQuery, MustNotQuery, ShouldQuery, etc.) - Add tests for field filters (TimeField, PortField, CountryField, etc.) - Add tests for response classes (SuccessResponse, ErrorResponse, etc.) - Test error handling and edge cases
- Replace black check with ruff format check - Add ruff lint check step
- Fix typo: example_get_subdomain -> example_get_subdomains - Apply ruff import sorting and formatting fixes
- Update CI to use Makefile targets (install, test, check-format, lint, audit) - Separate Windows job since make is not available - Fix formatting issues in example_client.py, field.py, response.py
Move GNU sed check inside the target recipe so it only fails when fix-trailing-whitespace is actually invoked, not at Makefile parse time.
- Add step to install GNU sed via brew on macOS runners - Revert Makefile to original gsed check at parse time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
make test)make lint)make check-format)